Add NU 6.1 support #1898
Merged
Add NU 6.1 support #1898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems that |
Merged
|
Blocked on zingolabs/infrastructure#97. |
|
I merged zingolabs/infrastructure#97 |
|
Bumped to latest running 1 test
test load_wallet::verify_old_wallet_uses_server_height_in_send ... FAILED
failures:
failures:
load_wallet::verify_old_wallet_uses_server_height_in_send
test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in
stderr ───
thread 'load_wallet::verify_old_wallet_uses_server_height_in_send' panicked at libtonode-tes
called `Result::unwrap()` on an `Err` value: ProposalError(Proposal(DataSource(CheckpointNot
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
────────────
Summary [ 261.698s] 117 tests run: 53 passed, 64 failed, 31 skipped
FAIL [ 61.722s] libtonode-tests::chain_generics chain_generics::generate_a_range_of_val
FAIL [ 58.690s] libtonode-tests::chain_generics chain_generics::ignore_dust_inputs
FAIL [ 60.700s] libtonode-tests::chain_generics chain_generics::note_selection_order
FAIL [ 61.705s] libtonode-tests::chain_generics chain_generics::send_shield_cycle
FAIL [ 61.730s] libtonode-tests::chain_generics chain_generics::simpool_insufficient_10
FAIL [ 60.697s] libtonode-tests::chain_generics chain_generics::simpool_insufficient_10
FAIL [ 61.707s] libtonode-tests::chain_generics chain_generics::simpool_insufficient_10
FAIL [ 59.691s] libtonode-tests::chain_generics chain_generics::simpool_insufficient_10
FAIL [ 61.715s] libtonode-tests::chain_generics chain_generics::simpool_insufficient_10
FAIL [ 61.721s] libtonode-tests::chain_generics chain_generics::simpool_insufficient_10
FAIL [ 61.734s] libtonode-tests::chain_generics chain_generics::simpool_insufficient_1_
FAIL [ 60.698s] libtonode-tests::chain_generics chain_generics::simpool_insufficient_1_
FAIL [ 61.703s] libtonode-tests::chain_generics chain_generics::simpool_insufficient_1_
FAIL [ 60.688s] libtonode-tests::chain_generics chain_generics::simpool_insufficient_1_
FAIL [ 61.711s] libtonode-tests::chain_generics chain_generics::simpool_insufficient_1_
FAIL [ 61.721s] libtonode-tests::chain_generics chain_generics::simpool_insufficient_1_
FAIL [ 33.239s] libtonode-tests::chain_generics chain_generics::simpool_no_fund_1_000_0
FAIL [ 39.209s] libtonode-tests::chain_generics chain_generics::simpool_no_fund_1_000_0
FAIL [ 42.019s] libtonode-tests::chain_generics chain_generics::simpool_no_fund_1_000_0
FAIL [ 69.084s] libtonode-tests::concrete basic_transactions::send_and_sync_with_multip
FAIL [ 62.121s] libtonode-tests::concrete fast::basic_scenario
FAIL [ 62.092s] libtonode-tests::concrete fast::create_send_to_self_with_zfz_active
FAIL [ 48.047s] libtonode-tests::concrete fast::diversified_addresses_receive_funds_in_
FAIL [ 49.009s] libtonode-tests::concrete fast::filter_empty_messages
FAIL [ 60.090s] libtonode-tests::concrete fast::message_thread
FAIL [ 60.084s] libtonode-tests::concrete fast::received_tx_status_pending_to_confirmed_with_mempool_monitor
FAIL [ 60.925s] libtonode-tests::concrete fast::send_not_fully_synced
FAIL [ 56.842s] libtonode-tests::concrete fast::tex::send_to_tex
FAIL [ 63.905s] libtonode-tests::concrete fast::unified_address_discovery
FAIL [ 42.109s] libtonode-tests::concrete fast::utxos_are_not_prematurely_confirmed
FAIL [ 46.216s] libtonode-tests::concrete fast::value_transfers
FAIL [ 55.065s] libtonode-tests::concrete propose_orchard_dust_to_sapling
FAIL [ 56.108s] libtonode-tests::concrete send_all::ptfm_general
FAIL [ 62.987s] libtonode-tests::concrete send_all::ptfm_insufficient_funds
FAIL [ 63.054s] libtonode-tests::concrete send_all::ptfm_zero_value
FAIL [ 46.946s] libtonode-tests::concrete send_all::toggle_zennies_for_zingo
FAIL [ 69.961s] libtonode-tests::concrete slow::by_address_finsight
FAIL [ 60.924s] libtonode-tests::concrete slow::dust_sends_change_correctly
FAIL [ 70.945s] libtonode-tests::concrete slow::factor_do_shield_to_call_do_send
FAIL [ 52.026s] libtonode-tests::concrete slow::from_t_z_o_tz_to_zo_tzo_to_orchard
FAIL [ 71.105s] libtonode-tests::concrete slow::list_value_transfers_check_fees
FAIL [ 61.992s] libtonode-tests::concrete slow::mempool_and_balance
FAIL [ 56.200s] libtonode-tests::concrete slow::mempool_spends_correctly_marked_pending_spent
FAIL [ 93.919s] libtonode-tests::concrete slow::note_selection_order
FAIL [ 58.092s] libtonode-tests::concrete slow::rescan_still_have_outgoing_notes::check_list_value_transfers_across_rescan
FAIL [ 49.955s] libtonode-tests::concrete slow::rescan_still_have_outgoing_notes::external_send
FAIL [ 43.019s] libtonode-tests::concrete slow::rescan_still_have_outgoing_notes::self_send
FAIL [ 45.933s] libtonode-tests::concrete slow::sapling_dust_fee_collection
FAIL [ 46.132s] libtonode-tests::concrete slow::sapling_incoming_sapling_outgoing
FAIL [ 61.027s] libtonode-tests::concrete slow::sapling_to_sapling_scan_together
FAIL [ 50.070s] libtonode-tests::concrete slow::self_send_to_t_displays_as_one_transaction
FAIL [ 67.077s] libtonode-tests::concrete slow::send_funds_to_all_pools
FAIL [ 37.016s] libtonode-tests::concrete slow::send_heartwood_sapling_funds
FAIL [ 24.999s] libtonode-tests::concrete slow::send_mined_sapling_to_orchard
FAIL [ 50.003s] libtonode-tests::concrete slow::send_orchard_back_and_forth
FAIL [ 57.985s] libtonode-tests::concrete slow::send_to_transparent_and_sapling_maintain_balance
FAIL [ 49.952s] libtonode-tests::concrete slow::send_to_ua_saves_full_ua_in_wallet
FAIL [ 49.732s] libtonode-tests::concrete slow::sends_to_self_handle_balance_properly
FAIL [ 45.822s] libtonode-tests::concrete slow::t_incoming_t_outgoing_disallowed
FAIL [ 46.681s] libtonode-tests::concrete slow::test_scanning_in_watch_only_mode
FAIL [ 53.892s] libtonode-tests::concrete slow::zero_value_change
FAIL [ 51.936s] libtonode-tests::concrete slow::zero_value_change_to_orchard_created
FAIL [ 48.751s] libtonode-tests::concrete slow::zero_value_receipts
FAIL [ 54.717s] libtonode-tests::wallet load_wallet::verify_old_wallet_uses_server_height_in_send
error: test run failed |
dorianvp
force-pushed
the
deps/update-lrz-crates
branch
from
dda9df0 to
7a71dd0
Compare
These errors seem to be related to how input selection is handled. |
|
Down to 28 failing tests now. Most of the failures show something like: thread 'fast::filter_empty_messages' panicked at libtonode-tests/tests/concrete.rs:694:10:
called `Result::unwrap()` on an `Err` value: SendError(TransmissionError(TransmissionFailed("Error: SendResponse { error_code: -22, error_message: \"TX decode failed\" }"))) |
|
As a control test against dev I run: Against the latest commit on this branch I get 18 tests run with 16 fails. I think I will attempt to resolve conflicts with dev first. Test fail log: cargo nextest run fast::basic_scenario
Finished `test` profile [optimized + debuginfo] target(s) in 0.25s
------------
Nextest run ID 7c589eb0-6404-4e7f-91df-3cea7932a4e8 with nextest profile: default
Starting 1 test across 17 binaries (147 tests skipped)
FAIL [ 6.028s] libtonode-tests::concrete fast::basic_scenario
--- STDOUT: libtonode-tests::concrete fast::basic_scenario ---
running 1 test
test fast::basic_scenario ... FAILED
failures:
failures:
fast::basic_scenario
test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 52 filtered out; finished in 6.03s
--- STDERR: libtonode-tests::concrete fast::basic_scenario ---
thread 'fast::basic_scenario' panicked at /home/nattyb/src/zingolabs/zingolibs/update-lrz-crates/zingolib/src/testutils/scenarios.rs:252:35:
called `Result::unwrap()` on an `Err` value: SyncError(ServerError(RequestFailed(Status { code: InvalidArgument, message: "GetBlock: getblock failed, error: error parsing block: parsing block header: solution length is not 1344 as expected", metadata: MetadataMap { headers: {"content-type": "application/grpc"} }, source: None })))
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
------------
Summary [ 6.028s] 1 test run: 0 passed, 1 failed, 147 skipped
FAIL [ 6.028s] libtonode-tests::concrete fast::basic_scenario
error: test run failed |
|
Zaino depends on a rev-pinned version of infrastructure: https://github.com/zingolabs/zaino/blob/dbc0cfc5d52d4c9507c1b0f6d8067978a45e3d5f/Cargo.toml#L35 Therefore it won't be affected by a change to dev, so I have merged: zingolabs/infrastructure#110 |
|
Certain crates do not build successfully when compiled independently. However, this breakage was not introduced in this PR. |
dorianvp
requested review from
Oscar-Pepper,
zancas,
fluidvanadium,
juanky201271 and
nachog00
dorianvp
commented
Sep 11, 2025
| ) -> Result<(Lightwalletd, DarksideConnector), String> { | ||
| let lightwalletd = Lightwalletd::launch(LightwalletdConfig { | ||
| lightwalletd_bin: LIGHTWALLETD_BIN, | ||
| lightwalletd_bin: LIGHTWALLETD_BIN.unwrap(), // TODO: What should we do if there's no binary? |
There was a problem hiding this comment.
Changes coming from the new ExecutableLocation type. What should we do if there's no binary?
There was a problem hiding this comment.
Use an "expect" with a message stating that these "Full Stack" tests require an indexer_bin.
| zcash_client_backend::wallet::Note::Sapling(note), | ||
| zip32::Scope::External, | ||
| Position::from(1), | ||
| None, // mined_height. TODO: How should we use this here? |
There was a problem hiding this comment.
Are these values the correct ones? This was a change introduced in zcb
zancas
reviewed
Sep 11, 2025
zancas
previously approved these changes
Sep 11, 2025
zancas
approved these changes
Sep 12, 2025
|
I merged this on accident. I reset dev and a new branch to track the merge relationship here, in this PR: |
Oscar-Pepper
added a commit
to Oscar-Pepper/zingolib
that referenced
this pull request
Sep 18, 2025
juanky201271
added a commit
that referenced
this pull request
Sep 19, 2025
cleanup following review of nu6-1 support PR #1898
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades
zcash_client_backendand it's peer deps. Also adds support for NU 6.1.